On Thu, 9 Jul 2026 12:32:42 GMT, Coleen Phillimore <[email protected]> wrote:
>> src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c line 276:
>>
>>> 274: if (p == NULL) {
>>> 275: JNU_ThrowIOException(env, "Socket file path is null");
>>> 276: return JNI_FALSE;
>>
>> Does this need to (conditionally) call ReleaseStringPlatformChars before
>> returning?
>
> I don't think so. If p is null JNU_ReleaseStringPlatformChars has nothing to
> release.
Oops sorry, had been looking at the throw above in
src/jdk.attach/linux/native/libattach/VirtualMachineImpl.c where we throw but
don't return immediately, presumably so we do the cleanup, but yes this is
different. 8-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31407#discussion_r3551813020
