On Thu, 9 Jul 2026 11:07:07 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Dan's comments
>> - David's comments
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest2/libStopThreadTest2.cpp
> line 47:
>
>> 45: JNIEXPORT void JNICALL
>> 46: Java_StopThreadTest2_stopThread(JNIEnv* jni, jclass cls, jthread thread,
>> jobject exception) {
>> 47: jvmtiError err = jvmti->StopThread(thread, exception);
>
> Nit: Unneeded double space after the `=` sign.
Fixed.
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest2/libStopThreadTest2.cpp
> line 72:
>
>> 70: err = jvmti->AddCapabilities(&caps);
>> 71: if (err != JVMTI_ERROR_NONE) {
>> 72: LOG("Agent_OnLoad: error in JVMTI AddCapabilities: %d\n", err);
>
> This should return the `JNI_ERR` if the capabilities failed to be added.
Yes, fixed.
> test/hotspot/jtreg/serviceability/jvmti/vthread/StopThreadTest2/libStopThreadTest2.cpp
> line 75:
>
>> 73: }
>> 74:
>> 75: printf("Agent_OnLoad: finished\n");
>
> Better to use `LOG` instead of `printf` consistently.
Yes, fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31759#discussion_r3554438918
PR Review Comment: https://git.openjdk.org/jdk/pull/31759#discussion_r3554435528
PR Review Comment: https://git.openjdk.org/jdk/pull/31759#discussion_r3554438151
