On Thu, 2 Jul 2026 16:32:05 GMT, Chris Plummer <[email protected]> wrote:
> The test wasn't consuming all ThreadStartEvents, meaning that > eventSet.resume() wasn't called, which left threads suspended, which meant > the debuggee never exited, which caused the debugger to timeout waiting for > it to exit. Updated EventListener to ignore the `isConnected` flag until > there are no more events. > > The issue turned up about 1 in every 25000 runs. I ran about 75000 times with > the fix without any issues. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). I've added a question. Otherwise, it looks okay to me. test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequestManager/threadStartRequests/thrstartreq001.java line 226: > 224: // events until there are no more. So do a > continue here rather than > 225: // allowing continuing to be conditional on > isConnected below. > 226: continue; Q: Execution is already at the end of loop cycle. The `continue;` at line 226 is confusing and misleading. Why do we need it? ------------- PR Review: https://git.openjdk.org/jdk/pull/31756#pullrequestreview-4673617753 PR Review Comment: https://git.openjdk.org/jdk/pull/31756#discussion_r3560808006
