On Fri, 10 Jul 2026 08:14:33 GMT, Kieran Farrell <[email protected]> wrote:
>> src/hotspot/share/services/diagnosticCommand.cpp line 359:
>>
>>> 357: JavaCalls::call_static(&result, ik, method_name, signature, &args,
>>> CHECK);
>>> 358:
>>> 359: if (HAS_PENDING_EXCEPTION) {
>>
>> This is wrong. Now you have `CHECK` here you will never reach the if
>> statement when an exception is pending.
>>
>> And it remains unclear what affect exceptions will actually have on the
>> execution of the command - what gets returned to the user via the jcmd
>> invocation?
>
> That `CHECK` is from a different method and was updated in error, I’ve
> reverted it now
>
> as for the `showsettings` method I had updated it to use one exception
> handling style 'CHECK' so `attachListener.cpp` prints the pending exception
> to the user.
Okay - exception handling looks okay now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31742#discussion_r3567282384
