On Tue, 7 Jul 2026 08:23:56 GMT, Kieran Farrell <[email protected]> wrote:
>> src/hotspot/share/services/diagnosticCommand.cpp line 483: >> >>> 481: // resolve sun.launcher.LauncherHelper >>> 482: Symbol* klass_sym = vmSymbols::sun_launcher_LauncherHelper(); >>> 483: Klass* k = SystemDictionary::resolve_or_fail(klass_sym, true, CHECK); >> >> Why is exception handling here completely different to that from >> `java_lang_String::create_from_str` below? > > my understanding from previous comments was to add custom exception handling > to the `create_from_str` call as which the class initialisation call > previously had. Should I use custom local exception handling across the > method or should it follow the more common pattern in this file and use > CHECK/built-in handling and keep local exception handling only after > `JavaCalls::call_static()` instead? I'm trying to understand why you have different approaches to exceptions at different places in the same method. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31742#discussion_r3536201779
