On Wed, 8 Jul 2026 01:49:41 GMT, Dean Long <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2900 commits: >> >> - Merge branch '8317277' into jep401_sub_review_8317278 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - Merge >> >> Merge jdk-28+5 >> - 8386602: [lworld] C2: assert(n != top() || r->in(pnum) == top()) failed: >> live value must not be garbage >> >> Reviewed-by: thartmann >> - 8386499: [lworld] java/util/Arrays/ArraysEqCmpTest.java fails with >> unexpected layoutKind 5 >> >> Reviewed-by: chagedorn >> - 8387629: [lworld] Don't use apiNote for some recent JDI spec updates >> >> Reviewed-by: sspitsyn >> - 8387682: [lworld] Mention preview API in description of >> can_support_value_objects capability >> >> Reviewed-by: cjplummer >> - 8387657: [lworld] Object Tags section of JVMTI spec should make it clear >> that ObjectFree event is not sent for value objects >> >> Reviewed-by: sspitsyn, cjplummer >> - 8382226: [lworld] C2: Fix _copyOf/_copyOfRange intrinsic for flat >> abstract value class arrays >> >> Reviewed-by: qamai, thartmann >> - 8387612: [lworld] C2: assert(array_type->is_flat() || >> ideal.ctrl()->in(0)->as_If()->is_flat_array_check(&_gvn)) failed: Should be >> found >> >> Co-authored-by: Marc Chevalier <[email protected]> >> Reviewed-by: thartmann >> - ... and 2890 more: https://git.openjdk.org/jdk/compare/db987b1e...f1f6d35d > > src/hotspot/share/c1/c1_Runtime1.cpp line 451: > >> 449: >> 450: // TODO 8265122 This is currently dead code until the array factory >> methods are intrinsified >> 451: JRT_ENTRY(void, Runtime1::new_null_free_array(JavaThread* current, >> Klass* array_klass, jint length)) > > We don't normally push dead code or refer to bug IDs in comments. What's the > plan for this code? We intentionally left some TODOs in the code to keep track of post integration tasks. Other examples: https://github.com/openjdk/valhalla/blob/23a199ffb1c27605257f1be6d8a5b8bcfa85e25d/src/hotspot/share/opto/subtypenode.cpp#L50-L52 The plan is to address them during the JDK 28 time frame. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31122#discussion_r3569236955
