On Tue, 14 Jul 2026 12:38:46 GMT, Andrey Turbanov <[email protected]> wrote:
>> David Simms has updated the pull request incrementally with 11 additional >> commits since the last revision: >> >> - Merge branch '8317277' into jep401_sub_review_8317279 >> - Merge remote-tracking branch 'valhalla/lworld' into 8317277 >> - 8387703: [lworld] address batch of comments in mainline PR >> >> Co-authored-by: Tobias Hartmann <[email protected]> >> Reviewed-by: thartmann, dlong >> - 8387661: [lworld] move generate_return_value_stub() to SharedRuntime >> >> Reviewed-by: adinn, thartmann >> - 8387405: [lworld] is_always_flat_in_array should be always false >> >> Reviewed-by: thartmann >> - 8387686: [lworld] Update the JNI specification version for value types >> >> Reviewed-by: alanb, dsimms >> - 8387726: [lworld] JVMTI/JDWP/JDI docs cleanup >> >> Reviewed-by: sspitsyn, cjplummer >> - 8387673: [lworld] C2: clone() intrinsic does not throw >> CloneNotSupportedException for value classes not implementing Cloneable >> >> Reviewed-by: thartmann >> - 8387709: [lworld] Split Valhalla tests from tier1_compiler_3 to avoid >> task timeouts >> >> Reviewed-by: chagedorn >> - 8387350: [lworld] ObjectOutputStream.writeObject() doesn't throw >> InvalidClassException for Serializable instance with strict init fields >> >> Reviewed-by: alanb, jpai, thartmann >> - ... and 1 more: https://git.openjdk.org/jdk/compare/8a7fdc6e...78d2bcdb > > src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 125: > >> 123: super(name, link.getFileAttributes()); >> 124: this.file = null; >> 125: this.link = Objects.requireNonNull(link); > > That's too late to call `requireNonNull`. We already called > `link.getFileAttributes()` a few lines above Good catch. I've filed https://bugs.openjdk.org/browse/JDK-8388400 to address this. > src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java line 81: > >> 79: private final JrtPath rootPath = new JrtPath(this, "/"); >> 80: private volatile boolean isOpen; >> 81: private volatile boolean isClosable; > > now `isClosable` can be `final` Will be addresed in https://bugs.openjdk.org/browse/JDK-8388400 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3596237938 PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3596239247
