On Mon, 13 Jul 2026 10:39:02 GMT, Matthias Baesken <[email protected]> wrote:

>> Currently we still link the jvm lib on Windows with psapi.
>> But this seems to be unnecessary these days.
>> If we want to use the older API, we can compile with -DPSAPI_VERSION=1 and 
>> link psapi; but this is not done for hotspot.
>> (btw it's done for some jdk libs :
>> 
>> https://github.com/openjdk/jdk/blob/6e5bfcc6450512b4b974ed4afa067547552a0847/make/modules/jdk.attach/Lib.gmk#L35
>> https://github.com/openjdk/jdk/blob/6e5bfcc6450512b4b974ed4afa067547552a0847/make/modules/jdk.management/Lib.gmk#L35
>> 
>> but not in the hotspot build).
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Matthias Baesken has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Remove psapi linkage from other libs too

Looks good.
I would hope for somebody from build or serviceability to have a look as well.

-------------

Marked as reviewed by lucy (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/31846#pullrequestreview-4735243230

Reply via email to