On Fri, 31 Jul 2026 13:14:36 GMT, Coleen Phillimore <[email protected]> wrote:

>> test/hotspot/jtreg/serviceability/dcmd/thread/PrintRawMonitorLockTest.java 
>> line 132:
>> 
>>> 130:                 break;
>>> 131:             }
>>> 132:         }
>> 
>> Nit: The loop above can iterate forever if the `break` at line 130 does not 
>> happen.
>
> I rewrote this to loop 100 times instead then reporting failure if it doesn't 
> pass within 100 times. I hope this test won't be cursed on slower systems or 
> windows.

The "loop forever" version would trigger the timeout handler and then we would 
get a core etc and be able to see why it has not completed. Now we will just 
fail but we won't know why.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32092#discussion_r3700503027

Reply via email to