On Wed, 5 Aug 2026 19:04:14 GMT, Chris Plummer <[email protected]> wrote:

>>> So while data[] might have all R and V register values, no code ever does 
>>> something like reference data[V0].
>> 
>> Yes, but it is needed if DWARF instruction refers them.
>> `DwarfParser` would get `DWARF_Register` enum value like this, thus 
>> registers what appears in instruction should be defined.
>> 
>> 
>> enum DWARF_Register reg = static_cast<enum DWARF_Register>(read_leb(false));
>> 
>> 
>> Should this possibility be documented (in definition of `DWARF_Register` for 
>> example)?
>
>> Should this possibility be documented (in definition of DWARF_Register for 
>> example)?
> 
> I would document in the java code where the registers are symbolically 
> referenced from DwarfParser.cpp.

@plummercj I added comments to AARCH64ThreadContext.java. Is it enough?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/31999#issuecomment-5199244692

Reply via email to