On Wed, 5 Aug 2026 18:25:22 GMT, Chris Plummer <[email protected]> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   review: fixed typo in section ID
>
> src/hotspot/share/prims/jvmti.xml line 938:
> 
>> 936:     that a <jvmti/> agent can associate with an object.
>> 937:     Value objects can be tagged by <jvmti/> but the tag is associated 
>> with the object's
>> 938:     field values, as it has no identity.
> 
> Suggestion:
> 
>     Value objects can be tagged by <jvmti/> but the tag is associated with the
>     values of the object's fields, as it has no identity.
> 
> I think it reads a little bit better this way, but I'm fine with what you 
> have also. But either wording still is going to require the reader to 
> "connect to dots" to come to an understanding of what this really means to 
> them. I guess we can wait and see if there is feedback from developers.

I struggle to grasp the implications of tagging an object's field values rather 
than the object.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32211#discussion_r3726440743

Reply via email to