On Wed, 12 Aug 2026 11:26:43 GMT, Coleen Phillimore <[email protected]> wrote:
>> Fredrik Bredberg has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> commits since the last revision: >> >> - Update two after review >> - Merge branch 'master' into 8389325_remove_use_object_monitor_table_flag >> - Updated after review >> - Merge branch 'master' into 8389325_remove_use_object_monitor_table_flag >> - 8389325: Remove the UseObjectMonitorTable flag and related code > > src/hotspot/share/oops/markWord.hpp line 266: > >> 264: ShouldNotCallThis(); >> 265: return markWord(0); >> 266: } > > Should you just remove this? Or is that for a next revision? Don't want to delay this PR, so next ([JDK-8389938](https://bugs.openjdk.org/browse/JDK-8389938)) revision. > src/hotspot/share/oops/markWord.hpp line 269: > >> 267: >> 268: bool has_monitor_pointer() const { >> 269: return false; // Locking with OM table does not use markWord for >> monitors. > > Also, why not remove this one too? Don't want to delay this PR, so I'll defer it to [JDK-8389938](https://bugs.openjdk.org/browse/JDK-8389938). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32257#discussion_r3766042854 PR Review Comment: https://git.openjdk.org/jdk/pull/32257#discussion_r3766051537
