On Mon, 17 Aug 2026 22:18:19 GMT, Leonid Mesnik <[email protected]> wrote:
>> test/jdk/jdk/internal/vm/ThreadSnapshot/ThreadLockClassInit.java line 31: >> >>> 29: * @modules java.base/jdk.internal.vm >>> 30: * @run main ThreadLockClassInit >>> 31: * @run main/othervm -Xcomp -XX:-Inline >>> -XX:CompileCommand=compileonly,*ThreadSnapshot*::* ThreadLockClassInit >> >> If running with -Xcomp then this test should probably be flagless. > > The test support execution with any flags. So no need to make it flagless. > I don't see now how it could be very useful right now, but not harmful as for > the most of our tests. The standard practice is to don't restrict the > execution in such cases. Well it is redundant to run it in a Xcomp batch as it already uses Xcomp. And really this only cares about this specific compiled-code path so I see no value running it with different GC, or virtual threads or ... ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32363#discussion_r3802029879
