On Wed, 19 Aug 2026 23:22:01 GMT, Shiv Shah <[email protected]> wrote:

> LingeredApp currently always runs its loop on the main thread, so the jtreg 
> virtual thread factory never applies to it. With this change the launcher 
> forwards the test.thread.factory property to the child, and the app runs its 
> loop on a thread from the factory when one is set. The default path is 
> unchanged.
> 
> One heap dump test limits the virtual thread scheduler to a single carrier on 
> purpose, so it now calls the loop directly on the current thread instead, and 
> mainLoop was made public for that. The SA heap dump test is problem listed 
> for virtual runs, it trips a separate SA issue with virtual threads.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

test/lib/jdk/test/lib/apps/LingeredApp.java line 635:

> 633:      * For apps that cannot run on a virtual thread, e.g. when the test 
> limits
> 634:      * the virtual thread scheduler.
> 635:      */

This comments is a bit misleading or confusing. I think saying less would be 
better. Maybe just drop the 2nd sentence.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32460#discussion_r3824660008

Reply via email to