On Tue, 25 Aug 2026 16:09:14 GMT, Coleen Phillimore <[email protected]> wrote:
>> Fix a number of smaller issues surrounding ErrorLogTimeout, some of which I >> introduced with https://bugs.openjdk.org/browse/JDK-8303861: >> >> - Make ErrorLogTimeout an `unsigned`. Its "number of seconds", and unsigned >> gives us 130+ years, which is enough for the error log timeout. >> - Clarified the special value "0" to mean "no error log timeout" >> - renamed TIMESTAMP_TO_SECONDS_FACTOR to the less confusing >> SECONDS_TO_NANOS_FACTOR, and removed the useless >> `VMError::get_current_timestamp()` wrapper. >> - Fixed the calculation of error step timeouts to actually use a 5-second >> cap as intended, and clarified the comment. >> - Test changes: Some tests relied on ErrorLogTimeout to be a uint64_t. >> Replaced those with a different parameter that still is. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > This looks good. Thanks @coleenp and @sspitsyn ! ------------- PR Comment: https://git.openjdk.org/jdk/pull/32510#issuecomment-5421274281
