On Wed, 26 Aug 2026 16:48:31 GMT, Oli Gillespie <[email protected]> wrote:
>> src/hotspot/share/services/heapDumper.cpp line 2206:
>>
>>> 2204: }
>>> 2205:
>>> 2206: if (CollectedHeap::is_filler_object(o)) {
>>
>> OK, so `mark_dormant_archived_object` filters objects with classes which
>> Java mirrors have not yet loaded. But for filler objects, I expect
>> `Universe::fillerArrayKlass()` and `vmClasses::FillerObject_klass()` to be
>> fully loaded at all times. So we can filter filler objects ignoring the
>> dormant class check. Could be marginally cheaper if we have lots of filler
>> objects.
>>
>> But also, it is likely a very thin papercut; so I do not insist.
>
> Thanks. I can move it above.
On a second thought, it is probably safer/OK to leave it here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32542#discussion_r3866583305
