On Wed, 26 Aug 2026 21:36:19 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Introduce FlattenedInline.java in SA
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java line
> 199:
>
>> 197: // This method would be used to instantiate flattened object.
>> 198: public Oop newOop(OopHandle handle, InlineKlass klass) {
>> 199: return (handle == null) ? null
>
> Can it really ever be null? This seems like it would be a bug.
`handle` should not be null so far, but I guess this method might be required
to accept null in future in some case (I cannot explain the example now). We
should refer null marker in flattened object when we need to handle it as null.
However SA might want to call `newOop()` for flattened *null* object in future
because oop instantiation is different from HotSpot in SA.
I can agree we treat as the bug if `null` is passed as `handle` here, and will
add null check in future if needs. Which do you like?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32310#discussion_r3869311728
