On Wed, 26 Aug 2026 21:35:55 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Introduce FlattenedInline.java in SA
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ObjectHeap.java line
> 198:
>
>> 196:
>> 197: // This method would be used to instantiate flattened object.
>> 198: public Oop newOop(OopHandle handle, InlineKlass klass) {
>
> Just want to make sure I'm understanding this correctly. `handle` is not
> actually a valid handle, but is instead an offset off of a valid handle. I
> think this should be made clear here.
I updated the comment to explain where `handle` points. Is it enough?
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Oop.java line 102:
>
>> 100:
>> 101: // Type test operations
>> 102: public boolean isInline() { return false; }
>
> This isn't used or overridden. It might be worth keeping around, but I think
> it needs to be overridden in Inline.
Added it into Inline.java in new commit.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32310#discussion_r3869261113
PR Review Comment: https://git.openjdk.org/jdk/pull/32310#discussion_r3869254955
