On Thu, 27 Aug 2026 14:23:11 GMT, Stefan Karlsson <[email protected]> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removed the assert, we have other checks for inconsistent locking > > src/hotspot/share/oops/markWord.hpp line 225: > >> 223: LP64_ONLY(assert(mask_bits(value(), >> valhalla_reserved_bit_in_place) == 0, >> 224: "Reserved bits should not be used. _value: " >> PTR_FORMAT, _value)); >> 225: return !is_lock_neutral() || !has_no_hash(); > > Pre-existing: The lock-bits is stale after the object monitor table removal. > I don't remember if you update this in the hash PR. Otherwise, we should > investigate these usages (in another PR) to see if they can be tweaked. `must_be_preserved()` should behave as `mark != prototype_mark` but the prototype is klass dependent with Valhalla / COH. But reading via the klass is cumbersome and/or costly. I think I can look at this in a separate RFE. But we must preserve objects which have some non-neutral locking bits. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32544#discussion_r3872727238
