On Fri, 28 Aug 2026 14:45:51 GMT, Dan Heidinga <[email protected]> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix comments. > > src/hotspot/share/classfile/loaderConstraints.cpp line 447: > >> 445: // Removes a class that was added to the table then class loading >> subsequently failed for this class, >> 446: // so we don't have a dangling pointer to InstanceKlass in the >> LoaderConstraintTable. >> 447: void LoaderConstraintTable::remove_failed_loaded_klass(InstanceKlass* >> klass, > > If we remove ClassLoader.addClass() and the potential OOM, then I don't think > we need this method at all. > > As a temporary step, we could change this to be an assert that ensures > `p->klass() != klass` to build confidence that this function is unnecessary > and remove it in a later cleanup I just looked again. This can't happen anymore. I'll add the assert though in case some new code comes along that fails after the klass is added to the constraint table. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32519#discussion_r3896176315
