On Mon, 31 Aug 2026 15:37:15 GMT, Shiv Shah <[email protected]> wrote:
>> This change converts the first nsk Suspend/Resume test from the shared agent >> thread handshake to direct native calls made by the test thread. The Java >> code passes the thread object directly to the native methods, removing the >> name-based lookup. Each validation now throws on failure instead of >> reporting through the shared status protocol. >> >> The old suspended state check could never actually fail the run, its status >> went through a value the test discarded, the rewrite makes all of it load >> bearing. >> >> The same schema is still used by sixteen additional tests, plus three tests >> that use only its status flag. I plan to convert them family by family, >> either in this PR or in follow up PRs depending on what works best for >> review. The shared header can be removed once it is no longer used >> >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Shiv Shah has updated the pull request incrementally with one additional > commit since the last revision: > > Use JVMTIUtils for suspendthrd01 and add getThreadState Test simplification to use the JVMTIUtils looks good. One nit/suggestion for the utils addition. Thanks test/hotspot/jtreg/testlibrary/jvmti/JVMTIUtils.java line 91: > 89: public static int getThreadState(Thread t) { > 90: return getThreadState0(t); > 91: } You don't need this public/private split if the Java code doesn't need to check the result from the native code. ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32585#pullrequestreview-5084740044 PR Review Comment: https://git.openjdk.org/jdk/pull/32585#discussion_r3909946299
