On Tue, 1 Sep 2026 11:20:07 GMT, Stefan Karlsson <[email protected]> wrote:
>> Johan Sjölen has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Support reference layout
>> - Rename to NoValue
>
> src/hotspot/share/oops/layoutKind.hpp line 151:
>
>> 149: _null_marker_offset(NoValue),
>> 150: _sizes() {
>> 151: set_size_in_bytes_of(LayoutKind::REFERENCE, UseCompressedOops ?
>> sizeof(narrowOop) : oopSize);
>
> FWIW, we already have a runtime constant for this:
> Suggestion:
>
> set_size_in_bytes_of(LayoutKind::REFERENCE, heapOopSize);
Cheers! I'm not the only one that doesn't know about this (I grepped the code
base for `UseCompressedOops`).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32276#discussion_r3911777817
