On Tue, 1 Sep 2026 19:09:31 GMT, Daniel D. Daugherty <[email protected]> wrote:

>> Since [JDK-8389325](https://bugs.openjdk.org/browse/JDK-8389325) 
>> `ObjectMonitor::_metadata` only contains a copy of the object’s hash code. 
>> But:
>> 
>> 1. A `ObjectMonitorTable` lookup get the hash directly from the object’s 
>> mark word, and ...
>> 2. ... no synchronization code uses the copy stored in the monitor.
>> 
>> Therefore this PR removes the redundant `_metadata` field and its related 
>> metadata/hash accessors, diagnostics, and serviceability support.
>> 
>> Passes tier1-5 tests successfully on supported platforms.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/ui/MonitorCacheDumpPanel.java
>  line 68:
> 
>> 66:     if (raw) tty.print("(Raw Monitor)");
>> 67:     tty.println();
>> 68:     tty.println("  _header: 0x" + 
>> Long.toHexString(mon.header().value()));
> 
> Missed in the rename from `_header` to `_metadata`?

Yes, someone didn't rename from `_header` to `_metadata` back in the day. But 
it doesn't matter now, since I removed the entire line. :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32573#discussion_r3914292849

Reply via email to