On Fri, 4 Sep 2026 07:33:03 GMT, Stefan Karlsson <[email protected]> wrote:
>> JEP 401 delivered the preview feature of Value Objects. >> >> During the lifetime of the Valhalla project there were many ideas and names, >> and at one point the value types were called inline types. The HotSpot code >> was changed to use the name "inline types" instead of "value types" (and >> inline klass instead of value klass) >> [JDK-8249257](https://bugs.openjdk.org/browse/JDK-8249257). >> >> Later the concept and name "inline type" were dropped, but HotSpot retained >> the name. This causes confusion when working with the code. Some reasons: >> >> 1) There's no obvious connection to what's described in JEP 401 or the Java >> code. >> >> 2) It is easy to incorrectly assume that these are types that have been >> flattened (inlined) into other objects. >> >> 3) The name clash with C++'s concept of inlining >> >> My proposal is that we revert back to talking about "values" instead of >> "inlines", and that we do this before JDK 28 ships, so that we don't have a >> release where we use the "inline" terminology. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Stefan Karlsson has updated the pull request incrementally with two > additional commits since the last revision: > > - One more nit > - Review comments from Aleksey Reviewed `c1/` and `ci/`. Just one small thing. src/hotspot/share/c1/c1_InstructionPrinter.cpp line 30: > 28: #include "ci/ciInstance.hpp" > 29: #include "ci/ciObject.hpp" > 30: #include "ci/ciValueKlass.hpp" I am not sure why this include is needed in this file. I was able to build JDK without it. ------------- Marked as reviewed by kvn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/32673#pullrequestreview-5115211062 PR Review Comment: https://git.openjdk.org/jdk/pull/32673#discussion_r3935717566
