On Thu, 10 Sep 2026 17:00:45 GMT, Ioi Lam <[email protected]> wrote:
>> src/hotspot/share/cds/aotMapLogger.cpp line 886:
>>
>>> 884: }
>>> 885: } else {
>>> 886: // Was this a bug before this change?
>>
>> I added this as a marker to show that there was a bug here. It should be
>> removed before integration:
>> Suggestion:
>
> I removed it. It wasn't a bug before, as the `_fake_oop` would have been
> adjusted with an unsafe type cast to make `fd->offset()` work.
It seemed to me that the old patch in this PR was broken, and this comment was
added to point that out.
>> src/hotspot/share/oops/flatArrayKlass.cpp line 436:
>>
>>> 434: } else {
>>> 435: ValuePayloadContext vpc{vk, fa->value_offset_as_int(index,
>>> layout_helper())};
>>> 436: FieldPrinter print_field(st, fa, /*indent*/0, &vpc);
>>
>> I guess this is a preference, but maybe let everything breath a little ...
>> Suggestion:
>>
>> FieldPrinter print_field(st, fa, /* indent */ 0, &vpc);
>
> Fixed. I also changed the indent to 1 to make the output similar to
> aotMapLogger:
>
>
> {0x000000071800fd00} - klass: 'Point'[] - flags: is_cloneable_fast
>
> - length: 3
> - Index 0 offset 16:
> - final value flat 'x' (fields 0x00000003) 'Ljava/lang/Integer;' @16
> LayoutKind: NULL_FREE_NON_ATOMIC_FLAT Flat value null-free type field
> 'java/lang/Integer':
> - private final value 'value' (fields 0x00000000) 'I' @16 1111
> (0x00000457)
OK.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32565#discussion_r3982535889
PR Review Comment: https://git.openjdk.org/jdk/pull/32565#discussion_r3982550291
