On Thu, 17 Sep 2026 15:47:12 GMT, Matthias Baesken <[email protected]> wrote:
> The gcc static analyzer reports this issue : > > > src/jdk.jdwp.agent/share/native/libjdwp/signature.c:49:28: warning: > dereference of NULL 'tagPtr' [CWE-476] [-Wanalyzer-null-dereference] > src/jdk.jdwp.agent/share/native/libjdwp/signature.c:50:12: warning: > dereference of NULL 'tagPtr' [CWE-476] [-Wanalyzer-null-dereference] > > > Normally the > char *tagPtr = strchr(signature, SIGNATURE_END_ARGS); > call should not return NULL; but maybe (in theory with bad/malformed input) > it could happen so better add a NULL check. > In debug builds, the following JDI_ASSERT should handle it. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Thanks for the review! Btw. should I keep the `JDI_ASSERT(tagPtr);` after my added code with the NULL check added? ------------- PR Comment: https://git.openjdk.org/jdk/pull/32929#issuecomment-5726783816
