On Mon, 5 Oct 2026 11:35:37 GMT, Stefan Karlsson <[email protected]> wrote:
>> The include guards follow a simple pattern: Take the relative path, >> upper-case the letters and replace / and . with _. There are places where >> this has deteriorated. I'd like to push a trivial fix to clean that up. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Stefan Karlsson has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains four additional > commits since the last revision: > > - Minor copyright issue > - Merge remote-tracking branch 'upstream/master' into 8393458_include_guards > - Review > - 8393458: Fix various include guard inconsistencies Looks good. Surprising how many file renames/moves did not update these include guards. Also somewhat surprising we have so much redundancy repeating os/cpu info in both the directory path and the file name. Thanks ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/33180#pullrequestreview-5423117247
