> The gcc static analyzer reports this issue :
> 
> 
> src/jdk.jdwp.agent/share/native/libjdwp/signature.c:49:28: warning: 
> dereference of NULL 'tagPtr' [CWE-476] [-Wanalyzer-null-dereference]
> src/jdk.jdwp.agent/share/native/libjdwp/signature.c:50:12: warning: 
> dereference of NULL 'tagPtr' [CWE-476] [-Wanalyzer-null-dereference]
> 
> 
> Normally the
> char *tagPtr = strchr(signature, SIGNATURE_END_ARGS);
> call should not return NULL; but maybe (in theory with bad/malformed input) 
> it could happen so better add a NULL check.
> In debug builds, the following JDI_ASSERT should handle it.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Matthias Baesken has updated the pull request incrementally with one additional 
commit since the last revision:

  GetMethodName - check success

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/32929/files
  - new: https://git.openjdk.org/jdk/pull/32929/files/8637ef4a..40619609

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=32929&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=32929&range=01-02

  Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/32929.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/32929/head:pull/32929

PR: https://git.openjdk.org/jdk/pull/32929

Reply via email to