On Fri, 9 Oct 2026 00:41:44 GMT, Yasumasa Suenaga <[email protected]> wrote:
>> Valhalla introduced new array type which hosts flattened value object,
>> however SA cannot inspect it.
>> Actually `FlatArray.iterateFields()` has following lines:
>>
>>
>> for (int index = 0; index < length; index++) {
>> // FIXME - call visitor.doXXX() for each component of each value object
>> }
>>
>>
>> This PR addressed it.
>>
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Yasumasa Suenaga has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Update bug id in ClhsdbInspectWithValueObject.java
> - Update testcase to check null in array
> - Implement getObjAt and getOopHandleAt
> - Merge branch 'master' into JDK-8381336
> - Fix
> - 8381336: SA FlatArray support is incomplete
Thank you for updates. Looks good now.
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/32849#pullrequestreview-5468651099
