On Fri, 9 Oct 2026 14:32:40 GMT, Stefan Karlsson <[email protected]> wrote:
> I hit a circular dependency involving oopCast.inline.hpp when I was changing > code in one of the *oop.inline.hpp files. One solution is to create an > oopCast.hpp file with the declarations and include it in oopCast.inline.hpp > before including the rest of the header files: > > https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md: > > All .inline.hpp files should include their corresponding .hpp file as the > first include line with a blank line separating it from the rest of the > include lines. Declarations needed by other files should be put in the .hpp > file, and not in the .inline.hpp file. This rule exists to resolve problems > with circular dependencies between .inline.hpp files. > > > I propose that we instead move oop_cast to oop.inline.hpp. > > I also made some cleanups to the surrounding type checking functions. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). This pull request has now been integrated. Changeset: 262d92d3 Author: Stefan Karlsson <[email protected]> URL: https://git.openjdk.org/jdk/commit/262d92d30cfb5b4c7b694e0076aac4d0d10fd555 Stats: 155 lines in 43 files changed: 44 ins; 94 del; 17 mod 8394182: Move oopCast.inline.hpp functions to oop.inline.hpp Reviewed-by: shade, sspitsyn ------------- PR: https://git.openjdk.org/jdk/pull/33287
