> I hit a circular dependency involving oopCast.inline.hpp when I was changing > code in one of the *oop.inline.hpp files. One solution is to create an > oopCast.hpp file with the declarations and include it in oopCast.inline.hpp > before including the rest of the header files: > > https://github.com/openjdk/jdk/blob/master/doc/hotspot-style.md: > > All .inline.hpp files should include their corresponding .hpp file as the > first include line with a blank line separating it from the rest of the > include lines. Declarations needed by other files should be put in the .hpp > file, and not in the .inline.hpp file. This rule exists to resolve problems > with circular dependencies between .inline.hpp files. > > > I propose that we instead move oop_cast to oop.inline.hpp. > > I also made some cleanups to the surrounding type checking functions. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision: Update cdsProtectionDomain.cpp ------------- Changes: - all: https://git.openjdk.org/jdk/pull/33287/files - new: https://git.openjdk.org/jdk/pull/33287/files/795147f9..1d6bd9a4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=33287&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33287&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/33287.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/33287/head:pull/33287 PR: https://git.openjdk.org/jdk/pull/33287
