On Thu, 15 Oct 2026 19:50:25 GMT, Serguei Spitsyn <[email protected]> wrote:

> The JVMTI SampledObjectAlloc spec has this statement:
>  "If another sampling interval is required, the user can call 
> SetHeapSamplingInterval with a strictly positive integer value, representing 
> the new sampling interval."
> 
> However, 0 is also a valid sampling interval as the JVMTI 
> SetHeapSamplingInterval spec states:
>   " Setting sampling_interval to 0 will cause an event to be generated by 
> each allocation supported by the system once the new interval is taken into 
> account. "
> 
> The SampledObjectAlloc spec has to state this instead:
>  "If another sampling interval is required, the user can call 
> SetHeapSamplingInterval with a non-negative integer value, representing the 
> new sampling interval."
>  
>  Testing: N/A
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Looks good.

-------------

Marked as reviewed by cjplummer (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/33389#pullrequestreview-5539270882

Reply via email to