> Valhalla introduced flattened value object, however SA cannot dump it into 
> heapdump e.g. `jhsdb jmap --binaryheap`.
> Actually HeapHprofBinWriter.java has following lines. Hence the user cannot 
> check flattened object from heapdump generated by SA.
> 
> 
>         case JVM_SIGNATURE_CLASS:
>         case JVM_SIGNATURE_ARRAY: {
>             if (field.isFlat()) {
>               // FIXME - we don't handle flattened fields yet. Just treat them
>               // as a null reference. See JDK-8381370.
>               writeObjectID(null);
> 
> 
> This PR addressed it.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Yasumasa Suenaga has updated the pull request with a new target base due to a 
merge or a rebase. The incremental webrev excludes the unrelated changes 
brought in by the merge/rebase. The pull request contains four additional 
commits since the last revision:

 - Re-enable HeapDumpTestWithActiveProcess.java
 - Merge branch 'master' into JDK-8381370
 - Use getFieldHolder() rather than getKlass()
 - 8381370: SA is not writing out flattened fields to the hprof file

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/33395/files
  - new: https://git.openjdk.org/jdk/pull/33395/files/1211d38f..b2df669c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=33395&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33395&range=01-02

  Stats: 31880 lines in 992 files changed: 16490 ins; 11622 del; 3768 mod
  Patch: https://git.openjdk.org/jdk/pull/33395.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/33395/head:pull/33395

PR: https://git.openjdk.org/jdk/pull/33395

Reply via email to