On Thu, 22 Oct 2026 03:54:38 GMT, Chris Plummer <[email protected]> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/utilities/AbstractHeapGraphWriter.java > line 115: > >> 113: throw new RuntimeException(exp); >> 114: } >> 115: } > > Using a finally block for this seems kind of odd. If there is an exception, > we probably don't want to be processing flatObjects. Also it seems odd to > process flatObjects but not call writeHeapRecordEpilogue(), even though it > doesn't do anything. I think the earlier "return false" should probably be > replaced with a "break", and also add a flag (something like "isThread") that > can be used to decide if the writeInstance() call should be skipped. I reverted the change to process `flatObjects()` just after `writeHeapRecordEpilogue()`. And also changed to exit loop for finding super class for handling thread object. They work on test/hotspot/jtreg/serviceability/sa and test/jdk/sun/tools/jhsdb. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33395#discussion_r4344592108
