On Tue, 27 Oct 2026 22:27:30 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fix comment typo > > test/hotspot/jtreg/serviceability/sa/TestLongAltRootPath.java line 4: > >> 2: * Copyright (c) 2026, Oracle and/or its affiliates. All rights reserved. >> 3: * ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license terms. >> 4: */ > > Why is this strange copyright header? > Should it be a usual OpenJDK header? Yes. I will fix that. > test/hotspot/jtreg/serviceability/sa/TestLongAltRootPath.java line 26: > >> 24: * @requires vm.hasSA >> 25: * @requires vm.gc != "Z" >> 26: * @requires os.family != "windows" > > Q: Do we have to exclude sanitizer with ? : > > * @requires !vm.asan > * @requires !vm.ubsan I'm not sure and I don't know how to test it. It seems we do this with some of our core file tests, but not all. I'm inclined to leave it off for now and let those that care about these tools add it later if needed. > test/hotspot/jtreg/serviceability/sa/TestLongAltRootPath.java line 71: > >> 69: // Launch "jhsdb jstack" on the core file. >> 70: ProcessBuilder pb = new ProcessBuilder(cmdStringList); >> 71: SATestUtils.addPrivilegesIfNeeded(pb); > > Q: Why would we need additional privileges? Adding privileges means adding sudo to the command. We do this with all the SA test. It is needed if not running as root on macOS. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33520#discussion_r4395047885 PR Review Comment: https://git.openjdk.org/jdk/pull/33520#discussion_r4395107446 PR Review Comment: https://git.openjdk.org/jdk/pull/33520#discussion_r4395086730
