On Tue, 3 Nov 2026 08:14:41 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Shiv Shah has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Rename to cont_popframe_reexecute_entry with its own CodeletMark, arm
>> returns nullptr, review comment wording
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 2556:
>
>> 2554: assert(_state->is_virtual(), "invariant");
>> 2555: if (frame_count == 0) {
>> 2556: // If the top frame is in the heap, PopFrame is not
>> supported.
>
> Nit: The comment at line 2556 is not fully correct. As is for compiled frames
> only.
> Should say: `If the top frame is compiled and in the heap...`
Fixed all
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32661#discussion_r4460195137
