On Wed, 4 Nov 2026 08:59:08 GMT, Gui Cao <[email protected]> wrote: >> Hi, please condiser. >> SA currently computes continuation entry frame pointers using the raw >> sizeof(ContinuationEntry), whereas HotSpot uses that size rounded up to two >> machine words. >> With the current 64-bit layout, the raw size is 56 bytes and the aligned >> size is 64 bytes. Consequently, SA computes frame pointers eight bytes too >> low on x86-64, AArch64, and RISC-V64. >> >> This change: >> - Aligns the size in the shared SA implementation, matching >> ContinuationEntry::size(). >> - Preserves RISC-V’s additional two-word FP adjustment. >> - Adds a cross-platform jtreg test that checks FP offsets using the attached >> JVM’s type metadata and a synthetic entry address, without depending on >> stack-walking behavior or virtual-thread timing. >> >> Testing: github ci >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Gui Cao has updated the pull request incrementally with one additional commit > since the last revision: > > Code format
Thanks all for the review. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33695#issuecomment-6647257322
