On Thu, 5 Nov 2026 01:14:13 GMT, Serguei Spitsyn <[email protected]> wrote:

>> Shiv Shah has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Comments on the frozen frame checks and the two deoptimization paths
>
> test/hotspot/jtreg/vmTestbase/nsk/jdwp/StackFrame/PopFrames/popframes001a.java
>  line 149:
> 
>> 147:                 // The first join unmounts the tested thread, leaving 
>> its caller in the
>> 148:                 // heap when PopFrame is executed. Code before this 
>> join must not deoptimize
>> 149:                 // this frame, as thawing an interpreted frame also 
>> thaws its compiled caller.
> 
> Nit: This comment is not easy to understand. The context need to be explained 
> that the `testedMethod()` is invoked two times because of the JVMTI 
> `PopFrame`.

Thanks, both reworded

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32661#discussion_r4482483612

Reply via email to