On Thu, 22 Oct 2026 02:51:58 GMT, Chris Plummer <[email protected]> wrote:
>> @plummercj >> [JDK-8381370](https://bugs.openjdk.org/browse/JDK-8381370) is focusing on >> hprof file, in other words GXL can be treated in another issue. So can I >> exclude change for GXL from this PR? > >> So can I exclude change for GXL from this PR? > > You can exclude supporting flat objects in HeapGXLWriter, but the issue is > that your current changes break HeapGXLWriter, even when not using > --enable-preview. You need to fix the override issue to keep HeapGXLWriterL > working. For example, when AbstractHeapGraphWriter calls > writeObjectArray((ObjArray)oop, flatObjects), there needs to be a > HeapGXLWriter.writeObjectArray() with the same signature. You can use the > existing HeapGXLWriter.writeObjectArray() that takes a single argument and > change it take both arguments and ignore flatObjects. @plummercj @sspitsyn Could you review again if you are ok? All of serviceability/sa tests passed on my Linux. ------------- PR Comment: https://git.openjdk.org/jdk/pull/33395#issuecomment-6620150908
