On Wed, 4 Nov 2026 08:01:07 GMT, Serguei Spitsyn <[email protected]> wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed risc-v instr
>
> test/hotspot/jtreg/compiler/escapeAnalysis/TestArrayCopyEliminationUncRematerialization.java
> line 291:
>
>> 289: """
>> 290: @Test
>> 291: @IR(counts = { IRNode.LOAD_#{typeAbbrev},
>> "=#{loadCountAdjusted}" },
>
> Q: Do I read it correctly that this updates accounts for a JVMTI
> availability? However, I do not see this tests requires JVMTI. Does this need
> an adjustment?
Yes, I updated the test to check if jvmti is included into the JDK.
> test/hotspot/jtreg/serviceability/jvmti/events/VMObjectAlloc/VMObjectAllocClone/VMObjectAllocCloneTest.java
> line 32:
>
>> 30: *
>> 31: * @run main/othervm/native -agentlib:VMObjectAllocClone -Xbatch
>> VMObjectAllocCloneTest
>> 32: */
>
> Q: Should this test make two runs with C1 and C2?
I thought that it would be expensive, but seems it works fast enough. So I
added default and C1/C2 specific runs.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33684#discussion_r4472503952
PR Review Comment: https://git.openjdk.org/jdk/pull/33684#discussion_r4472516328
