On Mon, 16 Nov 2026 14:58:38 GMT, Matthias Baesken <[email protected]> wrote:

> [JDK-8394922](https://bugs.openjdk.org/browse/JDK-8394922) identified and 
> removed a couple of unused macros, mostly on Linux with gcc.
> But when using '-Wunused-macros' on macOS aarch64, a couple more were 
> identified,
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Changes requested by avu (Committer).

src/java.base/unix/native/libnio/ch/UnixFileDispatcherImpl.c line 345:

> 343:     }
> 344: 
> 345:     // if MAP_SYNC and MAP_SHARED_VALIDATE are not defined then it is

Please move this comment close to the macro definition

-------------

PR Review: https://git.openjdk.org/jdk/pull/33918#pullrequestreview-5923019003
PR Review Comment: https://git.openjdk.org/jdk/pull/33918#discussion_r4588052814

Reply via email to