On 07/06/2012 07:52 PM, Christoph Hellwig wrote: > -/* 0x0010 was SD_FLAG_CMD_IO_LOCAL */ > -#define SD_FLAG_CMD_RECOVERY 0x0020 > +/* internal flags for hdr.flags, must be above 0x80 */ > +#define SD_FLAG_CMD_RECOVERY 0x0080
Well, SD_FLAG_CMD_XXX is not the opcode which use incremental numbering scheme, but instead use ORed number, that only 1,2,4,8 makes sense. So above 0x0080 looks strange, maybe we can specify two lower bits for gateway flag and two higher bits for inter-sheep flag? In this assumption, we can set #define SD_FLAG_CMD_RECOVERY 0x0100 Thanks, Yuan -- sheepdog mailing list [email protected] http://lists.wpkg.org/mailman/listinfo/sheepdog
