At Sun, 8 Jul 2012 13:26:03 -0400, Christoph Hellwig wrote: > > On Sun, Jul 08, 2012 at 12:08:24PM +0900, MORITA Kazutaka wrote: > > At Fri, 06 Jul 2012 07:52:03 -0400, > > Christoph Hellwig wrote: > > > > > > With this series all internal commands need to contain a protocol version, > > > and any external command that has a version set has it checked. > > > > > > This allows bumping the versions and handling nodes with different > > > protocol > > > levels a lot easier in the future. > > > > Applied, thanks! > > Should we still move the internal flags to sit above 0x800 instead of > 0x80?
The current code looks clean to me, which uses lower 7 bits for client flags so that they must be less than 0x80 like opcodes and error values. Thanks, Kazutaka -- sheepdog mailing list [email protected] http://lists.wpkg.org/mailman/listinfo/sheepdog
