On 2012年08月20日 12:53, MORITA Kazutaka wrote:
> At Thu,  9 Aug 2012 13:27:36 +0800,
> levin li wrote:
>>  
>> +struct vdi_iocb {
>> +    char *data;
> 
> Should be "char *name"?
> 

Yes

>> +    uint32_t data_len;
>> +    uint64_t size;
>> +    uint32_t base_vid;
>> +    int is_snapshot;
> 
> Should be "bool is_snapshot"?
> 

Here is_snapshot is 'snapid', I should rename it to 'snapid'

thanks,

levin

>> +    int nr_copies;
>> +};
>> +
> 
> Can we use this structure to lookup_vdi() and del_vdi(), too?
> 
> Thanks,
> 
> Kazutaka
> 

-- 
sheepdog mailing list
[email protected]
http://lists.wpkg.org/mailman/listinfo/sheepdog

Reply via email to