James Carlson wrote: > Vladimir Kotal writes: >> Unless the CRT advocate makes me to do any changes in this area or there >> is overall agreement being reached and the shell style document is >> finalized (and the kstyle tool produced and integrated into Cadmium [1]) >> the code will remain as is. > > Wow. I don't think I'd take that stance with a reviewer, especially > with something that is merely a matter of style.
Yeah, this was not a wise thing to do. I got annoyed by left/right sweeping and uncertainty of the rules, sorry about that. Good thing that Jan sits literally behind the corner from me so I can always easily buy him a beer :) >> It's somewhat disappointing to see raging discussion about the style >> when no one really looked at the test suite core in detail. > > Actually, it doesn't disappoint me at all. It most often means that > the reviewers are generally happy with the rest of the code, and are > fishing about for things on which to comment. (Sometimes it means > that they didn't _understand_ the code, and then it's a bad thing. > It's worth asking.) <snip> It's probably the level of expectations. Most of the code reviews for me are in depth live sessions which go through the changes line by line until everything is clear and correct (or everyone in the meeting room falls exhausted from his chair). v.
