Jan Friedel wrote: <snip>
> Nitpicking - is the semicolon separation really necessary? I see I's say it's as necessary as the double brackets. > some other cases within your code, where the semicolon hasn't > been separated. Do we have some reason for such separation? It > is not mentioned in the ksh style guidelines; yes, examples use > such separation, but at the same time you can see other > semicolons used throughout the code also separated from the > commads. It is unified unlike in your code. Frankly, I do not care about the ksh style as long as the code remains reasonably readable and functional. Unless the CRT advocate makes me to do any changes in this area or there is overall agreement being reached and the shell style document is finalized (and the kstyle tool produced and integrated into Cadmium [1]) the code will remain as is. It's somewhat disappointing to see raging discussion about the style when no one really looked at the test suite core in detail. v. [1] http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/tools/onbld/hgext/cdm.py
