[ 
https://issues.apache.org/jira/browse/SHINDIG-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Artemy Tregubenko updated SHINDIG-46:
-------------------------------------

    Attachment: patch

I've got something working. 

Probably most important part is replacing 
resp.getOutputStream().print(markup.toString());
with 
resp.getWriter().print(markup.toString());
and setting utf8 charset in servlet.

Most of other changes are replacements of byte arrays with strings.

I'm new to Java, so my code most probably needs review.

> gadgets.io.makeRequest malfunctions on non-ASCII web sites.
> -----------------------------------------------------------
>
>                 Key: SHINDIG-46
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-46
>             Project: Shindig
>          Issue Type: Bug
>          Components: Gadgets Server - Java
>            Reporter: Brian Eaton
>            Assignee: John Hjelmstad
>         Attachments: patch
>
>
> See this thread for background: 
> http://mail-archives.apache.org/mod_mbox/incubator-shindig-dev/200802.mbox/browser
> Short term, we should change the HTTP proxy code to always use UTF-8 as the 
> character set for converting remote content bytes to strings before returning 
> them to clients.  We should do this ASAP to prevent anyone from becoming 
> dependent on the current undefined behavior.
> Long term we might want to add some kind of character set detection, probably 
> via the HTTP content-type header.  IE style charset content sniffing would 
> probably not be a good idea.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to