[
https://issues.apache.org/jira/browse/SHINDIG-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12567194#action_12567194
]
Artemy Tregubenko commented on SHINDIG-46:
------------------------------------------
This patch refers to both sides: it tries to detect charset of input by
content-type header and also fixes output, as it's broken too.
You may check this utf8-coded widget:
http://muz.eu/misc/gadgets/translit.xml
http://localhost:8080/gadgets/ifr?url=http://muz.eu/misc/gadgets/translit.xml
When you open this url in your browser, there would be some cyrillic characters
(this proves shindig won't have troubles with input). When you load it via
shindig before my patch, these chars will transform to question marks. After
applying patch cyrillic is back again.
You may even test it directly: line
resp.getOutputStream().print("some non-ascii here");
will output question marks.
> gadgets.io.makeRequest malfunctions on non-ASCII web sites.
> -----------------------------------------------------------
>
> Key: SHINDIG-46
> URL: https://issues.apache.org/jira/browse/SHINDIG-46
> Project: Shindig
> Issue Type: Bug
> Components: Gadgets Server - Java
> Reporter: Brian Eaton
> Assignee: John Hjelmstad
> Attachments: patch
>
>
> See this thread for background:
> http://mail-archives.apache.org/mod_mbox/incubator-shindig-dev/200802.mbox/browser
> Short term, we should change the HTTP proxy code to always use UTF-8 as the
> character set for converting remote content bytes to strings before returning
> them to clients. We should do this ASAP to prevent anyone from becoming
> dependent on the current undefined behavior.
> Long term we might want to add some kind of character set detection, probably
> via the HTTP content-type header. IE style charset content sniffing would
> probably not be a good idea.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
