Might I pester some of you guys for feedback on this? I'm looking for a few things:
Non-committers (and "ordinary" users): 1. Do you think that writing a Guice module is easier than writing your own custom CrossServletState? (If you've done neither, then you probably don't care about the change anyway). 2. Is the new propreties-based configuration easier for you to understand, harder, or about the same? Committers (and anyone doing heavy integration work): 1. Do you feel that this is a better DI model than what we have at present? 2. Do you think it's a good idea for the project as a whole? 3. Do you have any better suggestions? I'm working on an updated patch that addresses some remaining clunkiness in RPC. Still unsure how to address Brian Eaton's security stuff since he hasn't sent us a patch with it yet. On Mon, Mar 24, 2008 at 7:09 PM, Kevin Brown <[EMAIL PROTECTED]> wrote: > I'm going to send this patch around in an incomplete form now (doesn't > handle request signing correctly) so that people can review it. I'm leaving > off the request signing because of efforts underway to refactor that code > anyway. > > I'll open up a JIRA issue with the patch. > > > On Mon, Mar 24, 2008 at 6:13 AM, Dave <[EMAIL PROTECTED]> wrote: > > > On Sun, Mar 23, 2008 at 11:45 PM, Kevin Brown <[EMAIL PROTECTED]> wrote: > > > On Sun, Mar 23, 2008 at 8:30 PM, Brian Eaton <[EMAIL PROTECTED]> > > wrote: > > > I share your concerns as well, having been burned all too often by > > > heavyweight "frameworks" that just make writing code more difficult > > than it > > > needs to be, and I was initially opposed to Guice, but having tried > > it first > > > hand I feel that it's a very elegant way to solve the problem, and it > > looks > > > like a variant of the same technique is going to wind up in JSR-299, > > so it's > > > a pretty sound decision going forward. I'm sure other people who've > > worked > > > with Guice directly (I believe both John H and Cassie have) will have > > more > > > insight. Initial impressions from my standpoint are pretty high. > > > > FWIW, we use Guice on Apache Roller, it's good stuff. it's definitely > > elegant and it's > > pretty lightweight both from a conceptual point of view and in physical > > size. > > > > - Dave > > > > > > -- > ~Kevin -- ~Kevin
