On Mon, Apr 28, 2008 at 2:12 AM, Paul Lindner <[EMAIL PROTECTED]> wrote:
> On Mon, Apr 28, 2008 at 12:11:18AM -0700, Kevin Brown wrote: > > Between code migration, patches, cross talk, misinformation, and mass > > confusion, we seem to have gotten into a state of complete dysfunction > when > > it comes to our http retrieval facilities. Is anyone else actively > working > > on cleaning this stuff up right now, or should I go ahead and clean this > up > > myself? > > I'd be willing to work on integrating our local Apache HttpClient into > whatever needs to be refactored. It's based off of 4.0 snapshot, but > is stable in production. > > HttpClient 4.0 has a nice clean design that may be worth mimicing. I had a JIRA issue open to migrate to HttpClient instead of using URLConnection, but I was still leaning towards a wrapper interface of some sort for various reasons, the main one being that the older HttpClient interface was difficult to extend. I haven't looked at the 4.0 interface yet, but I trust your judgment. One of the big things I think we should do is drop the tight coupling of the auth modes to the http retrieval, and instead have something dedicated to dealing with various types of auth. Packing oauth and request signing into the fetchers was an interesting experiment, but the end results are barely better than the previous revisions where stuff was crammed into the proxy. Now that there are multiple places where auth needs to be done, it's even uglier to deal with. I think a bunch of us had good ideas here, but they didn't really mesh well together and the end result is pretty poor. There's no time like the present to fix this stuff up, I suppose, since changes in the last few weeks, and those coming in the next few are dramatic enough that anyone doing heavy integration work is already in for a rough patch. > > -- > Paul Lindner > hi5 Architect > [EMAIL PROTECTED] >
